Ammo count not updated on pickup

[Cheo]

Hello, this might be considered a follow up on this issue : https://www.opsive.com/forum/index....ta-and-disabled-fire-after-reequipping.12466/

When picking up rifle ammo while holding a rifle, the inventory ammo count is not updated until we fire a shot or unequip and reequip the weapon.

This is a very awkward issue for any shooter game, and we'd really need this fixed for our upcoming demo. Please take a look at this, thanks.

 

[Sangemdoko]

Hey Cheo,
Sorry for the delay I was on Holiday for the past few weeks.
Thank you for reporting this issue. I'll take a look at what's going on when I can

 

[Sangemdoko]

I had a look. It was a silly mistake, we were listening to the event of adding ammo on the wrong object.

Replace this function around line 109 of the InventoryItemAmmo script:

/// <summary>
/// Updates the registered events when the item is equipped and the module is enabled.
/// </summary>
protected override void UpdateRegisteredEventsInternal(bool register)
{
    base.UpdateRegisteredEventsInternal(register);
    Opsive.Shared.Events.EventHandler.RegisterUnregisterEvent<ItemInfo, ItemStack>(register,
        m_Inventory, EventNames.c_Inventory_OnAdd_ItemInfo_ItemStack,
        OnAddItem);
    Opsive.Shared.Events.EventHandler.RegisterUnregisterEvent<ItemInfo>(register,
        m_Inventory, EventNames.c_Inventory_OnRemove_ItemInfo,
        OnRemoveItem);
    
    if (register) {
        var itemObject = ShootableAction.gameObject.GetCachedComponent<ItemObject>();
        SetItemObject(itemObject);
    }
}

Thank you for bringing this to our attention

 

[Cheo]

Thanks, I confirm it fixed the issue.